[phobos] Friendly reminder about pull requests
Jonathan M Davis
jmdavisProg at gmx.com
Mon Jul 2 00:22:35 PDT 2012
On Monday, July 02, 2012 09:04:14 David Nadlinger wrote:
> On 2 Jul 2012, at 7:11, Andrei Alexandrescu wrote:
> > I think I found what I want. At the bottom of the request there's
> > this: "Tip: You can also add notes to lines changed in a file under
> > Diff". The word "Diff" is linked, and the link seems to point to what
> > I need.
>
> You also get this view by clicking the Diff tab at the top (along
> Discussion and Commits). I agree that is incredibly useful – not sure
> how you »survived« so far… ;)
That's different though. That shows the diff between the commit before the pull
request and the last commit of the pull request. What Andrei seems to want is
the diff between the last commit of the pull request and the latest commit in
Phobos, which is very different, especially if the pull request has been around
for a while and a lot of other stuff has been committed.
- Jonathan M Davis
More information about the phobos
mailing list