[phobos] [D-Programming-Language/phobos] 64c5e3: Fix std.container.SList.linearRemove's TakeRange-b...

[Masahiro Nakagawa]

I don't know why, but I sent following post to Andrei directly...

We may have to define the rough rule of pull request.
If title hides the commits, the state of pull request is hard to know.
Separating pull requests are searchable and manageable.


Masahiro

On Mon, Jul 9, 2012 at 2:00 PM, Andrei Alexandrescu <andrei at erdani.com> wrote:
> Yah, the title doesn't reflect it. But a DList is an obvious continuation of
> std.container and I just didn't care about it being a separate pull request.
> The design of DList is fairly fixed, there's little need to e.g. have a
> formal review for it.
>
> Of course adding allocators will affect DList and all other containers, but
> I hope in a rather uniform way.
>
>
> Andrei
>
> On 7/9/12 12:33 AM, Masahiro Nakagawa wrote:
>>
>> I was a little surprised.
>> I didn't know DList proposal until after I read this mail.
>> Why did this pull request mix with fixing and adding new feature?
>>
>>
>> On Mon, Jul 9, 2012 at 12:07 PM, GitHub<noreply at github.com>  wrote:
>>>
>>>    Branch: refs/heads/master
>>>    Home:   https://github.com/D-Programming-Language/phobos
>>>    Commit: 64c5e3cffa58fecdb8ecb23fd175e5b8dcede2a7
>>>
>>> https://github.com/D-Programming-Language/phobos/commit/64c5e3cffa58fecdb8ecb23fd175e5b8dcede2a7
>>>    Author: Revellian<matz at localhost.localdomain>
>>>    Date:   2012-06-25 (Mon, 25 Jun 2012)
>>>
>>>    Changed paths:
>>>      M std/container.d
>>>
>>>    Log Message:
>>>    -----------
>>>    Fix std.container.SList.linearRemove's TakeRange-bug (if the TakeRange
>>> starts at the
>>> head of the SList, the whole list was removed instead of only the
>>> specified number.)
>>>
>>>
>>>    Commit: 0cae7ca6af24f6ad322edbe263f43f88b5c5650a
>>>
>>> https://github.com/D-Programming-Language/phobos/commit/0cae7ca6af24f6ad322edbe263f43f88b5c5650a
>>>    Author: Revellian<matz at localhost.localdomain>
>>>    Date:   2012-06-25 (Mon, 25 Jun 2012)
>>>
>>>    Changed paths:
>>>      M std/container.d
>>>
>>>    Log Message:
>>>    -----------
>>>    Added doubly-linked list (DList) to std.container
>>>
>>>
>>>    Commit: 61fa7c809cd4db2e214f5f2702690bd52436b7a0
>>>
>>> https://github.com/D-Programming-Language/phobos/commit/61fa7c809cd4db2e214f5f2702690bd52436b7a0
>>>    Author: Revellian<matz at localhost.localdomain>
>>>    Date:   2012-07-02 (Mon, 02 Jul 2012)
>>>
>>>    Changed paths:
>>>      M std/container.d
>>>
>>>    Log Message:
>>>    -----------
>>>    - Incorporate comments by andralex
>>>
>>>
>>>    Commit: e0757c5ded416d7c781a8199ae2f73eab7da3dc6
>>>
>>> https://github.com/D-Programming-Language/phobos/commit/e0757c5ded416d7c781a8199ae2f73eab7da3dc6
>>>    Author: Andrei Alexandrescu<andrei at erdani.com>
>>>    Date:   2012-07-08 (Sun, 08 Jul 2012)
>>>
>>>    Changed paths:
>>>      M std/container.d
>>>
>>>    Log Message:
>>>    -----------
>>>    Merge pull request #650 from revellian/master
>>>
>>> Fix std.container.SList.linearRemove's TakeRange-bug
>>>
>>>
>>> Compare:
>>> https://github.com/D-Programming-Language/phobos/compare/865c7a6f9d00...e0757c5ded41
>>>
>>> _______________________________________________
>>> phobos mailing list
>>> phobos at puremagic.com
>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos