[phobos] [D-Programming-Language/phobos] 4c2a8b: Add unittest for issue 9599, plus some other byLin...

GitHub noreply at github.com
Mon Aug 19 10:50:13 PDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 4c2a8bea355e2a980b21d41c5454fe7a34de1777
      https://github.com/D-Programming-Language/phobos/commit/4c2a8bea355e2a980b21d41c5454fe7a34de1777
  Author: Nick Treleaven <nick.treleaven at btinternet.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  Add unittest for issue 9599, plus some other byLine cases


  Commit: 8ff4bff0da031f85519fc5a2b845c2ab2bacedc6
      https://github.com/D-Programming-Language/phobos/commit/8ff4bff0da031f85519fc5a2b845c2ab2bacedc6
  Author: Nick Treleaven <nick.treleaven at btinternet.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  Fix unreferencing ByLine.file once empty

The file handle was not released for an empty text file.
Also, do not pretend empty() is const.


  Commit: 6061d747e4a0b430a957729f468f4c0141132871
      https://github.com/D-Programming-Language/phobos/commit/6061d747e4a0b430a957729f468f4c0141132871
  Author: Nick Treleaven <nick.treleaven at btinternet.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/base64.d

  Log Message:
  -----------
  Don't assume wrapped range has a const empty()


  Commit: ec1f0fdb9d3f4b9ffd3acd444d27195ffc6a15fb
      https://github.com/D-Programming-Language/phobos/commit/ec1f0fdb9d3f4b9ffd3acd444d27195ffc6a15fb
  Author: Nick Treleaven <nick.treleaven at btinternet.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  Fix Issue 9599 - File.byLine doesn't function properly with take

Calling take could wrongly pop an extra line from the range.
Solved by making ByLine use reference-counting.

Note: Just changing ByLine not to eagerly read the next line was not
sufficient to handle all cases properly (plus that makes empty() less
efficient).

Note: ByLine was documented until recently.


  Commit: dad4b536869aff4cc3fa4bd36362c70438440299
      https://github.com/D-Programming-Language/phobos/commit/dad4b536869aff4cc3fa4bd36362c70438440299
  Author: Nick Treleaven <nick.treleaven at btinternet.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  Don't let ByLine degenerate to a ByLineImpl


  Commit: 6de39acc16e9ed3ea206cc4e24f58511ac6cc458
      https://github.com/D-Programming-Language/phobos/commit/6de39acc16e9ed3ea206cc4e24f58511ac6cc458
  Author: Nick Treleaven <nick.treleaven at btinternet.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/stdio.d

  Log Message:
  -----------
  Change foreach byLine example to use take

Also remove 'If Char is mutable' because (currently) Char can't be
immutable.


  Commit: 7bc6e8153921b10eb61179ec318e01b825ff94c5
      https://github.com/D-Programming-Language/phobos/commit/7bc6e8153921b10eb61179ec318e01b825ff94c5
  Author: monarch dodra <monarchdodra at gmail.com>
  Date:   2013-08-19 (Mon, 19 Aug 2013)

  Changed paths:
    M std/base64.d
    M std/stdio.d

  Log Message:
  -----------
  Merge pull request #1433 from ntrel/byLine-take

Fix Issue 9599 - File.byLine doesn't function properly with take


Compare: https://github.com/D-Programming-Language/phobos/compare/5410c2d268dc...7bc6e8153921


More information about the phobos mailing list