[phobos] Automatic Pull Merging!

Brad Roberts braddr at puremagic.com
Sat Nov 16 13:47:54 PST 2013


On 11/16/13 1:23 PM, monarchdodra wrote:
> Is there a way to have this show up in the git pull pages?
>
> In regards to:
> https://github.com/D-Programming-Language/phobos/pull/1694
>
> You said:
>  > I'm removing the auto-merge tag on this commit until the JSON_TYPE comments are cleaned up.
>
> But when I reviewed, I was un-aware it was about to be merged, and did not remove the tag. There
> should be a visual queue on the pull page, and a mail should be sent, in the same way one is sent
> when a pull is merged.
>
> Other than that, I like it.

See:
   https://github.com/D-Programming-Language/dmd/pull/2783

I probably shouldn't have used that request for testing but since it's not passing tests I was 
confident it wouldn't accidentally merge while playing with it. :)




More information about the phobos mailing list