[phobos] [D-Programming-Language/phobos] 9211f1: fix Issue 10948 - BitArray.opEquals is invalid

GitHub via phobos phobos at puremagic.com
Sat May 31 03:37:10 PDT 2014


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 9211f1aad1bfdb306b1abcd67b278fda9cda78d2
      https://github.com/D-Programming-Language/phobos/commit/9211f1aad1bfdb306b1abcd67b278fda9cda78d2
  Author: Johannes Bblume <jblume at jblume.com>
  Date:   2014-05-27 (Tue, 27 May 2014)

  Changed paths:
    M std/bitmanip.d

  Log Message:
  -----------
  fix Issue 10948 - BitArray.opEquals is invalid

https://issues.dlang.org/show_bug.cgi?id=10948

Implemented the fix as proposed by nbelov on Bugzilla. Included are unit tests which would have triggered this bug and also fixed it in opCmp.

The issue was that the 32 bit expression "(1 << n)" was treated as being of size_t, which lead to incorrect bit patterns on 64 bit environments.


  Commit: 48afca0253bf51068bd64d26db15152e6a663204
      https://github.com/D-Programming-Language/phobos/commit/48afca0253bf51068bd64d26db15152e6a663204
  Author: Dmitry Olshansky <dmitry.olsh at gmail.com>
  Date:   2014-05-31 (Sat, 31 May 2014)

  Changed paths:
    M std/bitmanip.d

  Log Message:
  -----------
  Merge pull request #2204 from jblume/issue-10948

fix Issue 10948 - BitArray.opEquals is invalid


Compare: https://github.com/D-Programming-Language/phobos/compare/a3aab95bb5fd...48afca0253bf


More information about the phobos mailing list