[phobos] [D-Programming-Language/phobos] 2dc53b: Revert "mmfile.d: MmFile destructor changed not to...

GitHub via phobos phobos at puremagic.com
Fri Sep 18 03:01:37 PDT 2015


  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: 2dc53b839aa057519badf5bbce7da8647604d3cd
      https://github.com/D-Programming-Language/phobos/commit/2dc53b839aa057519badf5bbce7da8647604d3cd
  Author: Vladimir Panteleev <vladimir at thecybershadow.net>
  Date:   2015-09-01 (Tue, 01 Sep 2015)

  Changed paths:
    M std/mmfile.d

  Log Message:
  -----------
  Revert "mmfile.d: MmFile destructor changed not to cal enforce"

This reverts commit 4f3b3f4f1c613c2da877d15ae8382cbcd7abf9fe.

> This fix is incorrect and dangerous. You've removed a potential
> InvalidMemoryOperationError, which is deadly but easy to detect,
> but retained the possibility of closing the file handle of a
> completely unrelated file, if that file handle has since been
> reused. With this change, the bug will always be silent and much
> harder to find the real cause of.


  Commit: 1fc0fa1fa9c9e76a77af63114c7e781651a2d4de
      https://github.com/D-Programming-Language/phobos/commit/1fc0fa1fa9c9e76a77af63114c7e781651a2d4de
  Author: Vladimir Panteleev <vladimir at thecybershadow.net>
  Date:   2015-09-01 (Tue, 01 Sep 2015)

  Changed paths:
    M std/mmfile.d

  Log Message:
  -----------
  fix Issue 14868 - MmFile destructor seems to corrupt memory


  Commit: 836be856fa244b253ad8cc12d87668cf9202b295
      https://github.com/D-Programming-Language/phobos/commit/836be856fa244b253ad8cc12d87668cf9202b295
  Author: Vladimir Panteleev <vladimir at thecybershadow.net>
  Date:   2015-09-01 (Tue, 01 Sep 2015)

  Changed paths:
    M std/mmfile.d

  Log Message:
  -----------
  fix Issue 14994 - std.mmfile incorrectly handles map failure


  Commit: 290a94243f80585f6b42d022c2584fba51035c05
      https://github.com/D-Programming-Language/phobos/commit/290a94243f80585f6b42d022c2584fba51035c05
  Author: Vladimir Panteleev <vladimir at thecybershadow.net>
  Date:   2015-09-02 (Wed, 02 Sep 2015)

  Changed paths:
    M std/mmfile.d

  Log Message:
  -----------
  fix Issue 14995 - std.mmfile incorrectly handles errors in ctor


  Commit: b6dd28da4c338764ca82bdc9236e649f4bf56ebf
      https://github.com/D-Programming-Language/phobos/commit/b6dd28da4c338764ca82bdc9236e649f4bf56ebf
  Author: Dmitry Olshansky <dmitry.olsh at gmail.com>
  Date:   2015-09-18 (Fri, 18 Sep 2015)

  Changed paths:
    M std/mmfile.d

  Log Message:
  -----------
  Merge pull request #3619 from CyberShadow/pull-20150901-074214

std.mmfile - fix multiple issues


Compare: https://github.com/D-Programming-Language/phobos/compare/a327ed336194...b6dd28da4c33


More information about the phobos mailing list