[phobos] [dlang/phobos] 1ab23f: Change pack example to something simpler

GitHub via phobos phobos at puremagic.com
Wed Jul 27 12:08:58 PDT 2016


  Branch: refs/heads/master
  Home:   https://github.com/dlang/phobos
  Commit: 1ab23fa70b5c23b2f919fa4439989b20a72d4918
      https://github.com/dlang/phobos/commit/1ab23fa70b5c23b2f919fa4439989b20a72d4918
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Change pack example to something simpler

The original example for pack has too much stuff going on. Replacing it with a slimmer version that makes it a bit more clear what the impact of pack is. In particular, I feel like the asserts for shapes are necessary to make it obvious.


  Commit: f21cf84d99a480ec95ee7fdcfbf1c5d43c4bf98c
      https://github.com/dlang/phobos/commit/f21cf84d99a480ec95ee7fdcfbf1c5d43c4bf98c
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Update changes to modify [0][0] to [0, 0]

Addressing comments to change [0][0] to [0, 0]


  Commit: 56eb71c87126942641c6615666b6f4b39ee2d810
      https://github.com/dlang/phobos/commit/56eb71c87126942641c6615666b6f4b39ee2d810
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Update changes to have only one blank line

Was asked to have only one blank line. I assume this meant to split variables from asserts.


  Commit: c84e8098b8420947916efc10112c9378757124fe
      https://github.com/dlang/phobos/commit/c84e8098b8420947916efc10112c9378757124fe
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Fixing indentation and template parameters

Changing indentation to tab from 5 spaces for b. Also, change the formatting for template parameter to remove parentheses.


  Commit: 623d5b116e7beeafa6e3dfb056646a791db92830
      https://github.com/dlang/phobos/commit/623d5b116e7beeafa6e3dfb056646a791db92830
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Fixing space after std.range

Adding a space after std.range to pass Travis CI.


  Commit: 7ebce43896348d8272f6435fc8a8bd1468cb65b4
      https://github.com/dlang/phobos/commit/7ebce43896348d8272f6435fc8a8bd1468cb65b4
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Fixing white space

Trying to fix white space so that Travis CI passes.


  Commit: bdac4d2a938b269e23439f013a73dfea99fa03c7
      https://github.com/dlang/phobos/commit/bdac4d2a938b269e23439f013a73dfea99fa03c7
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Fixing white space on line 107

Fixing white space on line 107


  Commit: 5b14ca79c3a876e1a128d320fc5aa3fc04fc31b3
      https://github.com/dlang/phobos/commit/5b14ca79c3a876e1a128d320fc5aa3fc04fc31b3
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Removing extra line between blocks

Removing extra line between blocks


  Commit: 97efba121fabce299cb179b44a4fe06d9b57cf8b
      https://github.com/dlang/phobos/commit/97efba121fabce299cb179b44a4fe06d9b57cf8b
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Adding enums to avoid risk of GC allocation

Adding enums to avoid risk of GC allocation


  Commit: 4fbfeb685502340da7d32b7f2e673eb7a234662e
      https://github.com/dlang/phobos/commit/4fbfeb685502340da7d32b7f2e673eb7a234662e
  Author: jmh530 <jmh530 at users.noreply.github.com>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Changing enums to static immutable

Changing enums to static immutable because that is what Travis CI is telling me to do


  Commit: 52b694570c8836dedab108fde0c1364ddbf2e61b
      https://github.com/dlang/phobos/commit/52b694570c8836dedab108fde0c1364ddbf2e61b
  Author: Ilya Yaroshenko <ilyayaroshenko at gmail.com>
  Date:   2016-07-27 (Wed, 27 Jul 2016)

  Changed paths:
    M std/experimental/ndslice/selection.d

  Log Message:
  -----------
  Merge pull request #4631 from jmh530/patch-1

[ndslice] Change pack example to something simpler


Compare: https://github.com/dlang/phobos/compare/f9dd0f8e3f96...52b694570c88


More information about the phobos mailing list