[phobos] Making std.stdio.readf @safe

Jakub Łabaj via phobos phobos at puremagic.com
Tue Feb 7 09:59:28 PST 2017


On Tuesday, 7 February 2017 at 17:45:00 UTC, Andrei Alexandrescu 
wrote:
> This may be hasty. https://linux.die.net/man/2/flock does not 
> perform any unsafe operation, even for invalid arguments. -- 
> Andrei
>
> On 2/7/17 11:44 AM, Walter Bright via phobos wrote:
>>
>>
>> On 2/7/2017 6:00 AM, Jakub Łabaj via phobos wrote:
>>> Ok, so I have doubts whether these functions can be @trusted. 
>>> On the
>>> one hand
>>> they get just FILE* as an argument which (as I see it) makes 
>>> it safe
>>> interface.
>>> On the other hand FGETC is unlocked version of fgetc and 
>>> requires
>>> explicit lock
>>> to be used safely; FLOCK and FUNLOCK invocations should match,
>>> therefore there
>>> is also possibility to use it incorrectly. Personally I would 
>>> not mark
>>> them
>>> @trusted then, is it correct?
>>
>> I'd say you're right.
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos

FLOCK is aliased (at Linux) to 
https://linux.die.net/man/3/flockfile .  It may be safe on its 
own, but to avoid deadlock must be followed by call to unlock. 
Does it qualify to be @trusted in such case?


More information about the phobos mailing list