github: What to do when unittests fail?

Don nospam at nospam.com
Sun May 29 21:23:23 PDT 2011


Dmitry Olshansky wrote:
> On 24.05.2011 1:33, Andrej Mitrovic wrote:
>> I've cloned Phobos just a few minutes ago, and I've tried to build it 
>> with unittests, I'm getting these:
>>
>> Warning: AutoImplement!(C_6) ignored variadic arguments to the 
>> constructor C_6(...)
>>   --- std.socket(316) broken test ---
>>   --- std.regex(3671) broken test ---
> 
> Windows build is polluted by these messages that meant something 
> sometime ago (usually there was a test that failed, and it was commented 
> out for now).

Those messages are still meaningful. They are to remind people that the 
bugby tests haven't been fixed.
> Still it builds quite easily, though I skipped a couple of recent commits.
Yes, that's the idea.
> 
>> So what's the procedure now? Do I have to first revert to some earlier 
>> version of Phobos that has unittests that pass, before doing any 
>> edits? I want to edit an unrelated module and change some code 
>> (actually change a unittest), and make a pull request. This is for an 
>> already reported bug in bugzilla.
> Check auto-tester first ;)
> http://d.puremagic.com/test-results/
> 


More information about the Digitalmars-d-learn mailing list