counting words

monarch_dodra monarchdodra at gmail.com
Fri Jun 28 12:31:21 PDT 2013


On Friday, 28 June 2013 at 19:13:28 UTC, Brad Anderson wrote:
> On Friday, 28 June 2013 at 18:53:44 UTC, monarch_dodra wrote:
>> On Friday, 28 June 2013 at 17:59:58 UTC, bearophile wrote:
>>> monarch_dodra:
>>>
>>>> Well, I've had a PR open for this for about 8 months now...
>>>
>>> Do you have Phobos commit rights? If the answer is positive 
>>> then perhaps you can review and commit some Phobos code 
>>> written by Andrei and he can do the same with yours.
>>> Today it seems the major development bottleneck is the review 
>>> queue and not having enough writing of patches :-)
>>>
>>> Bye,
>>> bearophile
>>
>> The answer is negative though :(
>
> 95 merged phobos pull requests (109 total).  Long overdue, I'd 
> say.  I don't know if there is really a formal process to 
> getting write privileges but if any of the people who decide 
> are reading this I nominate monarch_dodra.

How did you come to that number? Total amount of pulls 
*submitted* ? I count 95 *closed* pull requests, but I think only 
about 50% of them ever made it through? I'm not sure how to check 
though (apart from counting 1 by 1...)

I'm unsure I'd be totally comfortable pulling inside phobos, but 
it *is* true that the queue is just getting longer and longer. 
There are some pulls just sitting there, submitted by trusted 
people (with pull rights), that are validated and reviewed, but 
are just waiting for a puller to do the deed. There needs to be a 
few more reviewers, the ones we have are doing a great job, but 
are overworked.

But I wouldn't want to hijack this thread, nor is learn really 
the place to talk about that.


More information about the Digitalmars-d-learn mailing list