Walter's annoying habits [OT]

[Unknown W. Brackets]

I disagree.

I call what you've named "code review", but mainly to make all code 
consistent in style.  This is not only because consistency is very 
important, e.g. for grep even, but moreover for another reason.

It greatly helps you learn the code.

If you think these people were just changing spaces to tabs, or the 
other way around, they were obviously wasting their time - especially if 
that took a week!

But if they were using this time to learn the code (and not just a small 
tiny subsection of it like most developers) this is of much greater gain 
for them and the project in the long-run.  A week is a small price to 
pay, and will make the code and project better in the future by quite a lot.

For any long-term project, I'd much rather a developer I managed spent a 
week learning a code base than a week trying to fix (and most likely 
having difficulty fixing) bugs during the same time frame.

In my opinion.  I would hesitate to so quickly slug people who do code 
reviews and coding style reviews if you don't know the full purpose of 
them.  Assuming there was a greater purpose, which there at least should 
have been.

-[Unknown]


> Rant,
> 
> All these seem petty to me, like complaining about someones formating 
> style.  If its useful then that's 100% better then not having it.
> 
> Ok, maybe slightly off topic:
> 
> Just my opinion,
> Knew one guy who spent a week reformatting (no design patterns just tabs 
> and naming conversions) everyone else code, and how did that help the 
> project?  As a further frustration some other coder who decided that his 
> formating style was superior so re-did the entire code style again a 
> month later.  While these programmers where obviously not professional I 
> wonder how far the project would have got if their time had actually 
> been spend fixing bugs or adding features.
> 
> Its all about making efficient use of ones time. Spending hours browsing 
> fixing typos is not a good use of time.  And it won't save much time in 
> the future (unlike good conventions on code design).  Also who knows 
> when the page will completely change.  Users who spot things like 
> spelling mistakes should report them, and Walter can get to them when 
> he's working on that page.
> 
> Now playing devils advocate now, people can be petty, and unfortunately 
>  D needs every user it can get.  I find this gen is strong with 
> programmers.  Therefore the quality of the D website (spelling ect...) 
> can turn these people types away.
> 
> -Joel