Recent Phobos changes

Leandro Lucarella llucax at gmail.com
Mon Mar 2 04:55:27 PST 2009


Jason House, el 26 de febrero a las 12:13 me escribiste:
> Don Wrote:
> 
> > Jason House wrote:
> > > There's been a flurry of commits lately. I noticed two strange things:
> > > 1. Unlike other intrinsics, bswap was not marked nothrow (only pure). This seems odd considering what the function does.
> > > 2. The math changes removed a lot of float-based prototypes when adding faster functions. That will cause difficulty for those who use floats. Ignoring speed loss for conversions, this will also require explicit casts.
> > > 
> > > Are these bugs, or am I missing something?
> > 
> > You're missing an intermediate compiler release <g>. You're seeing stuff 
> > in a peculiar intermediate state. Yes, there are weird bugs.
> 
> I'm hoping that pointing out stuff when I see it is helpful because they
> could get missed.  I don't know of the proper way to point out things or
> if I should just stay silent on the sidelines...

Good commit messages can help a lot here. Something like "this commit is
incomplete because float stuff is missing but this will be added in the
future" could help people who like to review the code to know if missing
stuff is intentional or an error/omission.

-- 
Leandro Lucarella (luca) | Blog colectivo: http://www.mazziblog.com.ar/blog/
----------------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------------
CAYO HUGO CONZI  ---  TENIA PUESTA PELUCA
	-- Crónica TV



More information about the Digitalmars-d mailing list