Pull requests for multiple issues?

Jesse Phillips jessekphillips+D at gmail.com
Fri Mar 18 07:26:38 PDT 2011


Jonathan M Davis Wrote:

> I would say that, generally speaking, unrelated changes should be separate pull 
> requests, whereas related changes should be grouped together into a single pull 
> request. Remember that it's all or nothing, so they're going to merge in all of 
> your changes or none of them. So, if it makes sense for them to all go together, 
> then put them together, but if they don't necessarily make sense to go together 
> and it _would_ make sense to accept some of them but not all of them,  then 
> separate them.

I thought when you were doing a pull request you could do whatever you wanted to bring in the changes you wanted, such as cherry-picking.

But I agree it makes review and acceptance easier. The reviewer should be able/expected to accept all/nothing.



More information about the Digitalmars-d mailing list