Review of Jose Armando Garcia Sancio's std.log

[Jacob Carlborg]

On 2012-02-16 10:57, Sönke Ludwig wrote:
> Am 16.02.2012 10:21, schrieb Jonathan M Davis:
>> On Monday, February 13, 2012 16:50:04 David Nadlinger wrote:
>>> Please post all feedback in this thread, and remember: Although
>>> comprehensive reviews are obviously appreciated, short comments are very
>>> welcome as well!
>>
>> Why does vlog even exist? It's a needless complication IMHO. Let the log
>> levels manage what does and doesn't get logged. I see no reason to add
>> the
>> concept of verbosity on top of that. It's a needless complication.
>>
>> Also, _please_ add a debug level. Personally, I'd argue for simply
>> copying
>> syslog's levels and matching them, since ideally any logging on Linux
>> would be
>> going to syslog anyway. But there are good reasons to have messages
>> beyond
>> info. I sure wouldn't want _all_ messages which don't indicate a
>> problem in
>> the app to be marked as info. For instance, what if I want to have info
>> displayed in release mode but want greater verbosity in debug mode?
>> I'd need
>> another log level which isn't there. Using the concept of verbosity to
>> try and
>> handle this is a needless complication. syslog has
>>
>> #define LOG_EMERG 0 /* system is unusable */
>> #define LOG_ALERT 1 /* action must be taken immediately */
>> #define LOG_CRIT 2 /* critical conditions */
>> #define LOG_ERR 3 /* error conditions */
>> #define LOG_WARNING 4 /* warning conditions */
>> #define LOG_NOTICE 5 /* normal but significant condition */
>> #define LOG_INFO 6 /* informational */
>> #define LOG_DEBUG 7 /* debug-level messages */
>>
>> And I'd like to at least see notice and debug added.
>>
>
> Well in addition to Debug I would also like to see Trace but it's f. ex.
> hard for me to tell the difference between Info and Notice and their
> names do not imply that certain severity order IMO. So I see a point in
> the argument that vlog() allows everyone to be happy without endless
> numbers of predefined log levels.. however I'm also not quite convinced.

I think this is way too many levels. Why not just define few levels 
(around three) and let the user define new levels when needed.

-- 
/Jacob Carlborg