"Good PR" mechanical check

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Wed Jan 13 05:47:19 PST 2016


On 1/13/16 12:19 AM, H. S. Teoh via Digitalmars-d wrote:
> On Tue, Jan 12, 2016 at 02:03:57PM -0500, Andrei Alexandrescu via Digitalmars-d wrote:
>> On 01/12/2016 08:42 AM, Martin DraĊĦar via Digitalmars-d wrote:
>>> Wouldn't it be sufficient to mandate usage of dfmt with proper
>>> settings before submitting a PR?
>>
>> That would suffice at least in the beginning. We also need to put dfmt
>> in tools, again a project that's been in limbo for a long time. --
>> Andrei
>
> In principle, I agree with mechanical checking of formatting (instead of
> the endless tedious nitpicking over the fine points of Phobos style),
> but, as Jonathan has brought up before, there are cases where human
> judgment is required and a tool would probably make a big mess of
> things.

BTW I recall it was your code containing a "switch(x){" that prompted 
this idea :o). True story. -- Andrei



More information about the Digitalmars-d mailing list