Some help with core/thread refactoring

[Nicholas Wilson]

On Friday, 9 August 2019 at 17:28:32 UTC, Stefanos Baziotis wrote:
> Hello everyone,
>
> I have been trying to refactor core/thread (with the help of 
> Nicholas Wilson).
> PR: https://github.com/dlang/druntime/pull/2689
>
> It seems it's something that the D community likes and I want 
> to progress on this.
>
> I get a failed test on AppVeyor and one on auto-tester.
>
> Both are related to Windows.
>
> -- On AppVeyor --
>
> It says there's a unittest that fails in exception.d. Now:
> - I can't find it in exception.d
> - It seems unrelated to the PR but it's kind of persistent 
> (it's the second time it appeared).

Appveyor is disabled on dmd, I don't remember why it hasn't yet 
been disabled on druntime. Don't worry about it.


> -- On auto-tester --
>
> I get an error when try to build Windows:
> std\concurrency.d(39): Error: module `thread` is in file 
> 'core\thread.d' which cannot be read.
>
> Have I missed something on the .mak files or smth?

Try adding a directory for it to copy into
https://github.com/dlang/druntime/blob/a3c1153f68ece9ff1842d2e95bc6d558a94e85d4/mak/WINDOWS#L32
i.e. insert
```
	mkdir $(IMPDIR)\core\thread
``
at line 59

Thats the only thing I can think of.

>
> Also, I'm trying to compile DMD on Windows to compile druntime 
> but it fails. I get an error like:
> std.process.ProcessException at std\process.d(755): Failed to 
> spawn new process

That may just be a flaky test, IIRC that and std.concurrency fail 
randomly (maybe some other ones too). If it is persistent, then 
it may be a problem.

> I don't know how to move forwards.

If those don't work let me know.