Discussion Thread: DIP 1029--Add throw as Function Attribute--Final Review

[Steven Schveighoffer]

On 4/17/20 1:01 PM, Adam D. Ruppe wrote:
> On Friday, 17 April 2020 at 14:39:26 UTC, Steven Schveighoffer wrote:
>> There is a difference between ignored and advice considered and not 
>> taken.
> 
> But even if it was all simply not taken, I'm OK with a response "I don't 
> care, take it or leave it" (though two of the bullets don't even have 
> that, just nothing)... but why are we wasting our time doing a 
> discussion thread to review the same document again?

I think it's just part of the red tape we created for ourselves!

But it also gives the chance to reiterate the importance of advice not 
taken, or rephrase the argument in a way that is more convincing.

> Again, the text is *identical* to the last review, so what does the DIP 
> manager expect from us this time that would be any different than last 
> time?

This is how things like this work. There are responses to the points 
made, and Walter didn't make any changes based on that.

It would also be possible to amend the DIP process such that if no 
changes are made before final review, it goes straight to formal 
assessment. Might not be a bad idea. It would save time too.

The document is here: 
https://github.com/dlang/DIPs/blob/master/docs/process-reviews.md#final-review

It says:

> The purpose of the Final Review is to provide one final opportunity to examine the revisions made in response to the Community Review rounds and further refine the DIP as necessary.

So, just amend that to say "If no revisions were made in response to the 
Community reviews, the DIP manager may forego the Final Review stage".

-Steve