[dmd-internals] Refactorings of dmd

Iain Buclaw via dmd-internals dmd-internals at puremagic.com
Sat Jun 20 03:18:31 PDT 2015

On 20 Jun 2015 11:50, "Martin Nowak via dmd-internals" <
dmd-internals at puremagic.com> wrote:
> On 05/25/2015 10:36 PM, Walter Bright via dmd-internals wrote:
> >
> >
> > On 5/25/2015 11:28 AM, Steven Schveighoffer via dmd-internals wrote:
> >> I feel like I need to respond to this. For the most part, I think the
> >> “bouncing the rubble” points are spot on. Reorganizing files can have
> >> benefits, and generally github is quite good at recognizing the move.
> >
> > My experience with github is it is quite terrible at showing a
> > reasonable diff when there's been whitespace and code motion changes.
> There is a nice trick, append ?w=1 to the diff page and it will omit
> whitespace changes.
> https://github.com/D-Programming-Language/phobos/pull/3431/files?w=1

And if that does not work, asking people to split up their commits into
easy to review chunks helps too.


If it helps speed up the review / merge process...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/dmd-internals/attachments/20150620/5155c66e/attachment.html>

More information about the dmd-internals mailing list