[Dlang-internal] Potential changes to DDoc

Jacob Carlborg doob at me.com
Tue Jan 23 17:37:40 UTC 2018


On 2018-01-23 05:56, David Gileadi wrote:

> I'd been avoiding a PR because I've been rebasing my changes on master 
> rather than merging, and I didn't want to cause confusion by rewriting 
> history. Should I switch to merging changes from master now that I 
> created a PR?

No, you should always rebase from master to get the latest changes from 
upstream. Branches for PRs are only temporary. Any changes that are 
performed in the PR after it's opened should be amended on the commit 
that introduced the code change.

-- 
/Jacob Carlborg


More information about the Dlang-internal mailing list