[phobos] Push or pull?

[Jonathan M Davis]

On Thursday 03 February 2011 03:30:16 Lars Tandle Kyllingstad wrote:
> So… now that we've moved to github, what is the preferred method for
> committing stuff to Phobos?  Should we continue pushing directly into
> the main repository, or should we do it "the git way" and send pull
> requests?
> 
> I have a suggestion for a workflow:
> 
> 1. Commit and push changes to own Phobos fork.
> 2. Send pull request to main Phobos repo.
> 3. Someone, which can be anyone in the Phobos team, reviews the code and
> merges it.
> 
> This gives a certain amount of quality control, in that at least one
> other person sees the code before it is admitted, while not putting the
> responsibility of reviewing all incoming code on one person.
> 
> How does that sound?

Well, I'm not sure that _every_ commit needs to be reviewed by another person 
(e.g. if you're just doing documentation changes or they're changes that you're 
sure of). And if you think that a commit doesn't really need anyone else to look 
at it, then pushing should be fine. But I do think that it makes good sense to 
use pull requests for any commits where you want someone else to look it over 
before it goes into the main branch. And, of course, patches from non-Phobos 
developers would come in through the pull mechanism rather than pushing.

- Jonathan M Davis