[phobos] Push or pull?

[Andrei Alexandrescu]

On 2/3/11 6:21 AM, Jonathan M Davis wrote:
> On Thursday 03 February 2011 03:30:16 Lars Tandle Kyllingstad wrote:
>> So… now that we've moved to github, what is the preferred method for
>> committing stuff to Phobos?  Should we continue pushing directly into
>> the main repository, or should we do it "the git way" and send pull
>> requests?
>>
>> I have a suggestion for a workflow:
>>
>> 1. Commit and push changes to own Phobos fork.
>> 2. Send pull request to main Phobos repo.
>> 3. Someone, which can be anyone in the Phobos team, reviews the code and
>> merges it.
>>
>> This gives a certain amount of quality control, in that at least one
>> other person sees the code before it is admitted, while not putting the
>> responsibility of reviewing all incoming code on one person.
>>
>> How does that sound?
>
> Well, I'm not sure that _every_ commit needs to be reviewed by another person
> (e.g. if you're just doing documentation changes or they're changes that you're
> sure of).

I think every commit should be seen by at least two persons. It has 
happened that an apparently trivial fix has caused trouble.

Andrei