What are the worst parts of D?

H. S. Teoh via Digitalmars-d digitalmars-d at puremagic.com
Wed Sep 24 15:31:00 PDT 2014


On Thu, Sep 25, 2014 at 08:20:32AM +1000, Daniel Murphy via Digitalmars-d wrote:
> "H. S. Teoh via Digitalmars-d"  wrote in message
> news:mailman.1573.1411584389.5783.digitalmars-d at puremagic.com...
> 
> >I am, as you yourself point out later. But it's frustrating when pull
> >requests sit in the queue for weeks (sometimes months, or, in the
> >case of dmd pulls, *years*) without any indication of whether it's on
> >the right track, and dismaying when your PR is just one of, oh, 100+
> >others that also all need attention, many of which are just
> >languishing there for lack of attention even though there is nothing
> >obviously blocking them, except perhaps the reviewers' / committers'
> >time / interest.
> 
> This is a misleading description of the situation with dmd pull
> requests.
> 
> There are lots of open pull requests, but the number has stayed fairly
> stable at ~100 for a long time.   This means they are getting merged
> or closed at the same rate they are created.
> 
> Some of them have certainly been forgotten by reviewers (sorry) but
> most of them need work, or implement controversial or questionable
> features.

IMNSHO, any PR that haven't been touched in more than, say, 1-2 months,
should just be outright closed. If/when the people involved have time to
work on it again, it can be reopened. If a feature is questionable or
controversial, shouldn't it be discussed on the forum and then a
decision made? Ignoring controversial PRs isn't getting us anywhere. At
the very least, if we can't decide, the PR should be closed (the
submitter can just reopen it later once he manages to convince people
that it's worthwhile -- that's what git branches are for).


[...]
> Things could always be better (can we clone Walter and Kenji yet?)

Yeah, if we could clone Kenji, it would speed things up dramatically.
:-)


> but the thing holding back issue XYZ is almost always the people who
> care about XYZ haven't fixed it yet, and the people who are fixing
> things don't care about XYZ.  This includes not only making patches,
> but convincing others it's something worth caring about.  Everybody
> has a different set of priorities they want everybody else to share.

I wish people would just make a decision about PRs, even if it's just to
close it with "sorry this is not worth the time", than to silently
ignore it and hope it would somehow go away on its own.


T

-- 
Always remember that you are unique. Just like everybody else. -- despair.com


More information about the Digitalmars-d mailing list