10 Tips for Better Pull Requests

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 09:49:30 PST 2015


On 1/16/15 9:41 AM, Tobias Pankrath wrote:
> That reply was not about my pull request specifically. Since it
> basically consists of two new files, it can stay there for months
> without generating any additional work for me. But it is a good
> counterexample to the »just close old stuff«-policy.

I agree that a hamfisted policy would do more harm than good. That's why 
it's so hard to define!

I'm thinking of something like: if there's $(legitimate) request for 
changes but the author is dormant for more than $(X) days, then close.

Andrei


Macros:

legitimate=?
X=?



More information about the Digitalmars-d mailing list