std.experimental.testing PR review

Atila Neves via Digitalmars-d digitalmars-d at puremagic.com
Fri Jun 26 07:28:39 PDT 2015


On Friday, 26 June 2015 at 13:14:40 UTC, Adam D. Ruppe wrote:
> Nothing jumps out at me as being especially bad. The posix 
> escape codes could also be Windows compatible by rewriting them 
> somehow, instead of building a string, make a struct message { 
> int color; string text; } or something that you pass to the 
> thread... but since that's an internal implementation detail 
> that isn't necessary to work, meh.

Yeah, I know. If I'm not mistaken you have a library for that but 
I didn't want to introduce a dependency. Doing colour output on 
Windows is just annoying so I left it.

If Phobos had something like that already though...

> The docs in package.d could show more higher level examples 
> too, before I looked at the code, I didn't realize there was 
> more to it.

I'll see if I can whip some more up.

Atila




More information about the Digitalmars-d mailing list